[ENH] address __array_wrap__ change incompatibility between numpy 2 and early torch or pandas versions
#1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
changed the title
__array_wrap__ change incompatibility between numpy 2 and early torch versions__array_wrap__ change incompatibility between numpy 2 and early torch or pandas versions
fkiraly
changed the title
__array_wrap__ change incompatibility between numpy 2 and early torch or pandas versions__array_wrap__ change incompatibility between numpy 2 and early torch or pandas versions
Collaborator
Author
|
Superseded by #1911 |
fkiraly
pushed a commit
that referenced
this pull request
Jul 9, 2025
…`pandas` (#1911) fixes #1764 Adding the comments from the Initial PR #1855 by @fkiraly The reason is that `numpy 2` added additional arguments to `__array_wrap__` which was interacting with `torch.Tensor.__array_wrap__` or `pandas.Series.__array_wrap__` that did not have said arguments on earlier versions, in `TorchNormalizer`. The warning can be avoided by explicit coercion to `torch` prior to mixed usage - avoiding mixed types across packages entirely. This also makes the coercions more explicit, enabling future refactors where we may want to move to more "clean" type assumptions instead of polymorphic union types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1764.
The reason is that
numpy 2added additional arguments to__array_wrap__which was interacting withtorch.Tensor.__array_wrap__orpandas.Series.__array_wrap__that did not have said arguments on earlier versions, inTorchNormalizer.The warning can be avoided by explicit coercion to
torchprior to mixed usage - avoiding mixed types across packages entirely.This also makes the coercions more explicit, enabling future refactors where we may want to move to more "clean" type assumptions instead of polymorphic union types.